containerapp-compose extension with support for compose files#4711
containerapp-compose extension with support for compose files#4711zhoxing-ms merged 17 commits intoAzure:mainfrom usepowershell:containerapp-preview
Conversation
ghost
requested a review
from 
ghost
added
the
|
containerapp-preview |
|
@yonzhan this is a completely different extension from the ACA extension my team owns, hence please have core-cli team review & provide help / feedback. Thanks! |
Could you please fix this import issue? |
|
@smurawski Please add exclusion in |
|
Please fix the |
|
@panchagnula Do you have a suggestion for the extension name? |
containerapp-dockercompose? |
@anthonychu I left the naming of the extension generic as Daria mentioned that there may be more things that you might want to experiment with as the main extension becomes more stable. Happy to change it at any point. |
usepowershell
changed the title
usepowershell
changed the title
|
@zhoxing-ms , this is something Steven & team planning to release in time for //BUILD for specific scenario support for Azure Container Apps, so please review this when you get a chance so they can make the necessary changes in a timely-fashion on their end as well. Thanks! |
src/containerapp-compose/azext_containerapp_compose/azext_metadata.json
Outdated
Show resolved
Hide resolved
|
Thank you for the review @zhoxing-ms I've made the required changes and have rebased on top of main (though that keeps moving). The build is green again. Anything else I need to address? |
src/containerapp-compose/azext_containerapp_compose/azext_metadata.json
Outdated
Show resolved
Hide resolved
...containerapp-compose/azext_containerapp_compose/vendored_sdks/azext_containerapp/commands.py
Outdated
Show resolved
Hide resolved
…steven.murawski@microsoft.com> Signed-off-by: Jessica Deen <jedeen@outlook.com>
…ski@microsoft.com> Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
…provided to support recordable tests
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
…ntainerapp. Use load_yaml_file from containerapp (remove copy/pasted code).
|
Anything left that would block us getting this shipped @zhoxing-ms ? |
6 participants
This is a preview extension to explore supporting consumption of Azure ContainerApps from a Docker Compose specification.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.